Remove unused or unneeded JarInfer flags #1050
Merged
+25
−107
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
JarInferRegexStripModelJar
andJarInferRegexStripCodeJar
options seem completely unused in our code base; so removing them is just a cleanup. (We should still document in the release notes.)We remove
JarInferUseReturnAnnotations
as well. Recall that JarInfer infers a@Nullable
return annotation if it sees the statementreturn null
in the body of the method. We remove this flag for a number of reasons:astubx
files rather than while reading them. I would expect that methods which havereturn null
in them should usually have a@Nullable
return. In cases where this is not desired, the configuration really should be on the generation side I think, excluding a few methods.@Nullable
annotations will be used independent of the flag setting. It only works for models read fromastubx
. So the most common internal use of JarInfer doesn't make use of this flag anyway.